qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC 05/18] cpus.h: include qemu-stdio.h


From: Eduardo Habkost
Subject: Re: [Qemu-devel] [RFC 05/18] cpus.h: include qemu-stdio.h
Date: Thu, 4 Oct 2012 10:14:48 -0300
User-agent: Mutt/1.5.21 (2010-09-15)

On Thu, Oct 04, 2012 at 02:00:57PM +0200, Igor Mammedov wrote:
> On Wed,  3 Oct 2012 10:29:01 -0300
> Eduardo Habkost <address@hidden> wrote:
> 
> > Needed for the definition of fprint_function.
> > 
> > This is not necessary right now, but it will be necessary if code that
> > doesn't include cpu-common.h includes cpus.h.
> Could be it cut to a separate standard hearders, and include only that on
> which it depends?

Are you talking about cpus.h, or qemu-stdio.h?

qemu-stdio.h is a new header, and is very small. I don't see how we
could split it further.

cpus.h is tiny, too, I don't see why we would split it.

> 
> > 
> > Signed-off-by: Eduardo Habkost <address@hidden>
> > ---
> >  cpus.h | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/cpus.h b/cpus.h
> > index 81bd817..b7c3708 100644
> > --- a/cpus.h
> > +++ b/cpus.h
> > @@ -1,6 +1,8 @@
> >  #ifndef QEMU_CPUS_H
> >  #define QEMU_CPUS_H
> >  
> > +#include "qemu-stdio.h"
> > +
> >  /* cpus.c */
> >  void qemu_init_cpu_loop(void);
> >  void resume_all_vcpus(void);
> 
> 

-- 
Eduardo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]