[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 05/18] cpus.h: include qemu-stdio.h
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [RFC 05/18] cpus.h: include qemu-stdio.h |
Date: |
Thu, 4 Oct 2012 16:05:09 +0200 |
On Thu, 4 Oct 2012 10:14:48 -0300
Eduardo Habkost <address@hidden> wrote:
> On Thu, Oct 04, 2012 at 02:00:57PM +0200, Igor Mammedov wrote:
> > On Wed, 3 Oct 2012 10:29:01 -0300
> > Eduardo Habkost <address@hidden> wrote:
> >
> > > Needed for the definition of fprint_function.
> > >
> > > This is not necessary right now, but it will be necessary if code that
> > > doesn't include cpu-common.h includes cpus.h.
> > Could be it cut to a separate standard hearders, and include only that on
> > which it depends?
>
> Are you talking about cpus.h, or qemu-stdio.h?
Ah, never mind, I see it is included for fprint_function().
>
> qemu-stdio.h is a new header, and is very small. I don't see how we
> could split it further.
>
> cpus.h is tiny, too, I don't see why we would split it.
>
> >
> > >
> > > Signed-off-by: Eduardo Habkost <address@hidden>
> > > ---
> > > cpus.h | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/cpus.h b/cpus.h
> > > index 81bd817..b7c3708 100644
> > > --- a/cpus.h
> > > +++ b/cpus.h
> > > @@ -1,6 +1,8 @@
> > > #ifndef QEMU_CPUS_H
> > > #define QEMU_CPUS_H
> > >
> > > +#include "qemu-stdio.h"
> > > +
> > > /* cpus.c */
> > > void qemu_init_cpu_loop(void);
> > > void resume_all_vcpus(void);
> >
> >
>
- Re: [Qemu-devel] [RFC 01/18] pc: create "PC" device class, (continued)
- Re: [Qemu-devel] [RFC 01/18] pc: create "PC" device class, Eduardo Habkost, 2012/10/04
- Re: [Qemu-devel] [RFC 01/18] pc: create "PC" device class, Eduardo Habkost, 2012/10/04
- Re: [Qemu-devel] [RFC 01/18] pc: create "PC" device class, Anthony Liguori, 2012/10/04
- Re: [Qemu-devel] [RFC 01/18] pc: create "PC" device class, Eduardo Habkost, 2012/10/04
- Re: [Qemu-devel] [RFC 01/18] pc: create "PC" device class, Anthony Liguori, 2012/10/04
[Qemu-devel] [RFC 04/18] move I/O-related definitions from qemu-common.h to a new header (qemu-stdio.h), Eduardo Habkost, 2012/10/03
[Qemu-devel] [RFC 06/18] hw/apic.c: rename bit functions to not conflict with bitops.h (v2), Eduardo Habkost, 2012/10/03
[Qemu-devel] [RFC 05/18] cpus.h: include qemu-stdio.h, Eduardo Habkost, 2012/10/03
[Qemu-devel] [RFC 02/18] pc: create PC object on pc_init1(), Eduardo Habkost, 2012/10/03
[Qemu-devel] [RFC 16/18] tests: support target-specific unit tests, Eduardo Habkost, 2012/10/03
[Qemu-devel] [RFC 11/18] target-i386: cpu_x86_init: allow APIC ID to be set by caller, Eduardo Habkost, 2012/10/03
[Qemu-devel] [RFC 07/18] kvm: create kvm_arch_vcpu_id() function, Eduardo Habkost, 2012/10/03
[Qemu-devel] [RFC 13/18] pc: set explicit APIC ID for CPUs, Eduardo Habkost, 2012/10/03
[Qemu-devel] [RFC 15/18] pc: set fw_cfg data based on APIC ID calculation (v2), Eduardo Habkost, 2012/10/03