[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] qemu-ga: ga_open_pidfile(): add new line to
From: |
Michael Roth |
Subject: |
Re: [Qemu-devel] [PATCH v2] qemu-ga: ga_open_pidfile(): add new line to pidfile |
Date: |
Thu, 4 Oct 2012 10:48:43 -0500 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Oct 03, 2012 at 06:40:01PM -0300, Luiz Capitulino wrote:
> FHS requires that pid files should end with a new line. Also change to
> snprintf() while there.
>
> Signed-off-by: Luiz Capitulino <address@hidden>
Reviewed-by: Michael Roth <address@hidden>
> ---
>
> o v2
>
> - use snprintf()
> - re-word changelog
>
> qemu-ga.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-ga.c b/qemu-ga.c
> index b747470..e4026f8 100644
> --- a/qemu-ga.c
> +++ b/qemu-ga.c
> @@ -255,7 +255,7 @@ static bool ga_open_pidfile(const char *pidfile)
> g_critical("Failed to truncate pid file");
> goto fail;
> }
> - sprintf(pidstr, "%d", getpid());
> + snprintf(pidstr, sizeof(pidstr), "%d\n", getpid());
> if (write(pidfd, pidstr, strlen(pidstr)) != strlen(pidstr)) {
> g_critical("Failed to write pid file");
> goto fail;
> --
> 1.7.12.315.g682ce8b
>