[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 05/11] vfio-pci: No spurious MSIs
From: |
Alex Williamson |
Subject: |
[Qemu-devel] [PATCH 05/11] vfio-pci: No spurious MSIs |
Date: |
Thu, 04 Oct 2012 16:18:05 -0600 |
User-agent: |
StGIT/0.14.3 |
FreeBSD doesn't like these spurious MSIs, remove them as they're
mostly paranoia anyway.
Signed-off-by: Alex Williamson <address@hidden>
---
hw/vfio_pci.c | 15 ---------------
1 file changed, 15 deletions(-)
diff --git a/hw/vfio_pci.c b/hw/vfio_pci.c
index 89e00ba..bca4083 100644
--- a/hw/vfio_pci.c
+++ b/hw/vfio_pci.c
@@ -322,21 +322,12 @@ static int vfio_msix_vector_use(PCIDevice *pdev,
* increase them as needed.
*/
if (vdev->nr_vectors < nr + 1) {
- int i;
-
vfio_disable_irqindex(vdev, VFIO_PCI_MSIX_IRQ_INDEX);
vdev->nr_vectors = nr + 1;
ret = vfio_enable_vectors(vdev, true);
if (ret) {
error_report("vfio: failed to enable vectors, %d\n", ret);
}
-
- /* We don't know if we've missed interrupts in the interim... */
- for (i = 0; i < vdev->msix->entries; i++) {
- if (vdev->msi_vectors[i].use) {
- msix_notify(&vdev->pdev, i);
- }
- }
} else {
VFIOIRQSetFD irq_set_fd = {
.irq_set = {
@@ -353,12 +344,6 @@ static int vfio_msix_vector_use(PCIDevice *pdev,
if (ret) {
error_report("vfio: failed to modify vector, %d\n", ret);
}
-
- /*
- * If we were connected to the hardware PBA we could skip this,
- * until then, a spurious interrupt is better than starvation.
- */
- msix_notify(&vdev->pdev, nr);
}
return 0;
- [Qemu-devel] [PATCH 00/11] vfio-pci cleanup and fixes, Alex Williamson, 2012/10/04
- [Qemu-devel] [PATCH 01/11] vfio-pci: Update slow path INTx algorithm, Alex Williamson, 2012/10/04
- [Qemu-devel] [PATCH 02/11] vfio-pci: Re-order map/unmap, Alex Williamson, 2012/10/04
- [Qemu-devel] [PATCH 03/11] vfio-pci: Unmap and retry DMA mapping, Alex Williamson, 2012/10/04
- [Qemu-devel] [PATCH 05/11] vfio-pci: No spurious MSIs,
Alex Williamson <=
- [Qemu-devel] [PATCH 06/11] vfio-pci: Roll the header into the .c file, Alex Williamson, 2012/10/04
- [Qemu-devel] [PATCH 07/11] vfio-pci: Don't peak at msi_supported, Alex Williamson, 2012/10/04
- [Qemu-devel] [PATCH 11/11] vfio-pci: Cleanup on INTx setup failure, Alex Williamson, 2012/10/04
- [Qemu-devel] [PATCH 08/11] vfio-pci: Use uintptr_t for void* cast, Alex Williamson, 2012/10/04
- [Qemu-devel] [PATCH 10/11] vfio-pci: Extend reset, Alex Williamson, 2012/10/04
- [Qemu-devel] [PATCH 04/11] vfio-pci: Rework MSIX setup/teardown, Alex Williamson, 2012/10/04
- [Qemu-devel] [PATCH 09/11] vfio-pci: Remove setting of MSI qsize, Alex Williamson, 2012/10/04