[Qemu-devel] [PATCH] fsdev: Don't ignore setfsuid/setfsgid return values

[M. Mohan Kumar]

From: "M. Mohan Kumar" <address@hidden>

In current implementation of setfsuid/setfsgid there is no way to know
if it failed by checking the return value. This patch assumes
setfsuid/setfsgid returns -1 in case of error. Eventually kernel code
needs to be fixed.

Signed-off-by: M. Mohan Kumar <address@hidden>
---
 fsdev/virtfs-proxy-helper.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
index f9a8270..ed5eede 100644
--- a/fsdev/virtfs-proxy-helper.c
+++ b/fsdev/virtfs-proxy-helper.c
@@ -290,9 +290,12 @@ static int setfsugid(int uid, int gid)
         CAP_DAC_OVERRIDE,
     };
 
-    setfsgid(gid);
-    setfsuid(uid);
-
+    if (setfsgid(gid) < 0) {
+        return -errno;
+    }
+    if (setfsuid(uid) < 0) {
+        return -errno;
+    }
     if (uid != 0 || gid != 0) {
         return do_cap_set(cap_list, ARRAY_SIZE(cap_list), 0);
     }
-- 
1.7.11.4