[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-ppc] [PATCH] PPC: KVM: Fix BAT put
From: |
Alexander Graf |
Subject: |
Re: [Qemu-devel] [Qemu-ppc] [PATCH] PPC: KVM: Fix BAT put |
Date: |
Fri, 5 Oct 2012 12:19:20 +0200 |
On 05.10.2012, at 05:29, David Gibson <address@hidden> wrote:
> On Fri, Oct 05, 2012 at 04:36:46AM +0200, Alexander Graf wrote:
>> In the sregs API, upper and lower 32bit segments of the BAT registers
>> are swapped when doing a set. Since we need to support old kernels out
>> there, don't bother to fix it in the kernel, but instead work around
>> the problem in QEMU by swapping on put.
>>
>> Signed-off-by: Alexander Graf <address@hidden>
>
> We should probably at least add warning comments to the kernel
> headers.
I would prefer to switch all of the sregs mess to one_reg and declare it
deprecated then :).
Alex
>
> --
> David Gibson | I'll have my music baroque, and my code
> david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
> | _way_ _around_!
> http://www.ozlabs.org/~dgibson