[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (LG
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (LGPL VGA BIOS port 0x501) |
Date: |
Fri, 05 Oct 2012 14:43:11 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
[was a private thread due to typo in qemu list address]
On 2012-10-05 14:40, Anthony Liguori wrote:
> Paolo Bonzini <address@hidden> writes:
>
>> Il 05/10/2012 00:06, Lucas Meneghel Rodrigues ha scritto:
>>> +static void debugexit_ioport_write(void *opaque, uint32_t addr, uint32_t
>>> val)
>>> +{
>>> + exit((val << 1) | 1);
>>> +}
>>> +
>>
>> This "| 1" might be the problem. Anthony, are you relying on it in
>> qemu-test and/or can you work out the changes if we use just
>> "exit(val)"?
>
> The reason for ' | 1' was to make sure that the guest couldn't trigger
> an exit(0).
>
> If there's a compelling reason to drop '| 1', I can adjust my tests
> accordingly.
assert(val); (or hw_error)
exit(val);
I would suggest.
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux
- Re: [Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (LGPL VGA BIOS port 0x501),
Jan Kiszka <=