Re: [Qemu-devel] Ping [PATCH 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation

[Blue Swirl]

On Fri, Oct 5, 2012 at 2:28 PM, Paolo Bonzini <address@hidden> wrote:
> Il 05/10/2012 15:20, Alberto Garcia ha scritto:
>> On Fri, Aug 31, 2012 at 06:09:11PM +0200, Andreas Färber wrote:
>>
>>>> Ping
>>>
>>> We are currently in Hard Freeze, new devices will not get accepted
>>> before the release, and our review may focus on bug fixes.
>>>
>>> http://wiki.qemu.org/Planning/1.2
>>>
>>> I remember having had a brief look through your patches and
>>> they looked pretty good modeling- and style-wise for an initial
>>> submission. Don't know the hardware though and haven't tested the
>>> patches so far.
>>
>> I wrote a small blog post about the work, including a bit more
>> information on how to test it:
>>
>> http://blogs.igalia.com/berto/2012/10/03/industrypack-qemu-and-linuxcon/
>>
>> The patches are still available here:
>>
>> http://patchwork.ozlabs.org/patch/179657/
>> http://patchwork.ozlabs.org/patch/179658/
>>
>> Is there anything else I should do in order to have this reviewed, or
>> should I contact someone else?
>
> I think the patches are pretty good, thanks for the contribution!  I'm
> adding another committer to the recipients.  Blue, can you take a look?

Endianness looks buggy, there's no way to turn off big endian mode and
DEVICE_NATIVE_ENDIAN should probably be DEVICE_LITTLE_ENDIAN.

Indentation of braces in switch cases looks strange.

Pointers to HW documentation and description how to test (or qtests)
would be nice.

I'd suppose addressing devices in the bus could be implemented more
efficiently with better use of memory API, now some of it is
reimplemented. Maybe Avi can propose something?

>
> Paolo