qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] versatile: Push lsi initialization to the end


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] versatile: Push lsi initialization to the end
Date: Fri, 5 Oct 2012 18:42:49 +0100

On 5 October 2012 18:30, Jan Kiszka <address@hidden> wrote:
> This is nasty, but there is no better way given current mux logic:
>
> As setting up the block device will trigger a qemu_bh_poll while there
> are qemu_chr open events in the queue, we have to register the UARTs
> and everything else that might be mux'ed first so that the right active
> frontend is already registered when the bottom-half is finally
> processed.

Yuck. I really don't like this -- why should the board model have
to care about implementation internals of lsi53c895a? It's just
plugging in a PCI card. And why only this device and not every
storage device in every board?

Nothing should actually start happening until the whole machine model
is completely set up and we've returned control to vl.c (and probably
not until we've done our first system reset). Any device which is
doing stuff early is broken and needs fixing.

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]