[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/4] command line fd passing using fd sets
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 0/4] command line fd passing using fd sets |
Date: |
Fri, 05 Oct 2012 12:26:16 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
On 10/05/2012 12:07 PM, Corey Bryant wrote:
> This series adds command line file descriptor passing support
> to the -drive option. This is a follow-on to the existing
> QMP fd passing support provided in the following patch series:
> comments.gmane.org/gmane.comp.emulators.qemu/165463
>
> An example of using the new -drive fd and opaque options:
> qemu-kvm -drive fd=24,opaque="rdwr:/path/file",index=0,media=disk
This feels wrong. Now you have to special-case encode the
fd=nn,opaque=xyz handling to EVERY command line argument that takes a
file name, not just -drive.
I'd much rather see:
qemu-kvm -fdset set=1,fds=24,25 \
-drive file=/def/fdset/1,index=0,media=disk
Where the creation of fdsets happens independently from use of those
sets, and therefore all other arguments that take file names can just
magically take the /dev/fdset/nnn notation that we already support from
the monitor.
Besides, my approach will let me pass in an O_RDONLY fd on 24 and O_RDWR
on 25 into the same set, whereas your approach creates a new set per fd,
so I can't add new fds to the set until the monitor is up and running.
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH 2/4] monitor: Enable adding an inherited fd to an fd set, Corey Bryant, 2012/10/05
[Qemu-devel] [PATCH 4/4] blockdev: Process -drive fd and opaque options, Corey Bryant, 2012/10/05
[Qemu-devel] [PATCH 1/4] monitor: Less restrictive fd matching for fd sets, Corey Bryant, 2012/10/05
Re: [Qemu-devel] [PATCH 0/4] command line fd passing using fd sets,
Eric Blake <=