Re: [Qemu-devel] [PATCH v10 14/14] target-mips-ase-dsp: Change TODO file

[Jia Liu]

Hi Johnson,

On Tue, Oct 9, 2012 at 1:19 AM, address@hidden
<address@hidden> wrote:
> On Mon, Oct 08, 2012 at 05:11:00PM +0000, Johnson, Eric wrote:
>> > -----Original Message-----
>> > From: address@hidden [mailto:qemu-devel-
>> > address@hidden On Behalf Of Jia Liu
>> > Sent: Monday, October 08, 2012 1:51 AM
>> > To: address@hidden
>> > Cc: address@hidden
>> > Subject: [Qemu-devel] [PATCH v10 14/14] target-mips-ase-dsp: Change TODO
>> > file
>> >
>> > Delete DSP r1 & DSP r2 from TODO file.
>> >
>> > Signed-off-by: Jia Liu <address@hidden>
>> > ---
>> >  target-mips/TODO |    2 --
>> >  1 file changed, 2 deletions(-)
>> >
>> > diff --git a/target-mips/TODO b/target-mips/TODO
>> > index 2a3546f..15d67cd 100644
>> > --- a/target-mips/TODO
>> > +++ b/target-mips/TODO
>> > @@ -6,8 +6,6 @@ General
>> >  - Unimplemented ASEs:
>> >    - MDMX
>> >    - SmartMIPS
>> > -  - DSP r1
>> > -  - DSP r2
>> >  - MT ASE only partially implemented and not functional
>> >  - Shadow register support only partially implemented,
>> >    lacks set switching on interrupt/exception.
>> > --
>> > 1.7.10.2 (Apple Git-33)
>> >
>>
>> As I stated in a prior email, there are microMIPS instruction encodings for 
>> the DSP instructions.  Should we change this to "microMIPS DSP r1 & r2 
>> encodings" instead of deleting?

Thank you very much to point this.

>>
>
> I agree, it should be changed to note that microMIPS DSP r1 & r2 are not
> supported.
>

And, I agree too :)

> --
> Aurelien Jarno                          GPG: 1024D/F1BCDB73
> address@hidden                 http://www.aurel32.net

Regards,
Jia.