[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/10] tcg: Use common code when failing to opti
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH 04/10] tcg: Use common code when failing to optimize |
|
Date: |
Tue, 09 Oct 2012 08:33:28 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
On 10/09/2012 08:25 AM, Aurelien Jarno wrote:
>> > @@ -639,6 +639,7 @@ static TCGArg *tcg_constant_folding(TCGContext *s,
>> > uint16_t *tcg_opc_ptr,
>> > gen_args += 2;
>> > args += 2;
>> > break;
>> > +
> Why this new line?
>
After the patch, all of the CASE blocks have a separator line.
It looked weird to have that be true of all but one case block
within that switch.
r~
- Re: [Qemu-devel] [PATCH 01/10] tcg: Split out swap_commutative as a subroutine, (continued)
[Qemu-devel] [PATCH 03/10] tcg: Swap commutative double-word comparisons, Richard Henderson, 2012/10/02
[Qemu-devel] [PATCH 02/10] tcg: Canonicalize add2 operand ordering, Richard Henderson, 2012/10/02
[Qemu-devel] [PATCH 04/10] tcg: Use common code when failing to optimize, Richard Henderson, 2012/10/02
[Qemu-devel] [PATCH 05/10] tcg: Optimize double-word comparisons against zero, Richard Henderson, 2012/10/02
[Qemu-devel] [PATCH 06/10] tcg: Split out subroutines from do_constant_folding_cond, Richard Henderson, 2012/10/02
[Qemu-devel] [PATCH 10/10] tcg: Optimize mulu2, Richard Henderson, 2012/10/02
[Qemu-devel] [PATCH 08/10] tcg: Constant fold add2 and sub2, Richard Henderson, 2012/10/02