Re: [Qemu-devel] [PATCH 4/7] savevm: Add VMSTATE_ helpers for target_phys_addr_t

[David Gibson]

On Tue, Oct 09, 2012 at 05:24:29PM +0100, Peter Maydell wrote:
> On 9 October 2012 13:53, David Gibson <address@hidden> wrote:
> > Well, the place I've used this (in patches yet to be posted) is saving
> > the state of the pseries machine itself.  Specifically, I use
> > VMSTATE_TPA_EQUAL to sanity check that the restored machine has the
> > same ram size as the saved machine.
> 
> This doesn't sound like the sort of check that should be in
> a specific machine model -- you should be able to rely on
> common qemu code to handle this. (If you can't then we need
> a check in the common code...)

Hm, true.  Very well, I'll drop it, and the VMSTATE_TPA patch as
well.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson