[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/14] i386: do not call helper to compute ZF/SF
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 09/14] i386: do not call helper to compute ZF/SF |
|
Date: |
Wed, 10 Oct 2012 08:42:47 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
Il 09/10/2012 21:16, Richard Henderson ha scritto:
>> > + int size = (s->cc_op - CC_OP_ADDB) & 3;
>> > + gen_ext_tl(reg, cpu_cc_dst, size, false);
>> > + tcg_gen_setcondi_tl(TCG_COND_EQ, reg, cpu_cc_dst, 0);
> I take that back. Should be (EQ, reg, reg, 0) here;
> you've dropped the extension on the floor.
More precisely it should be:
TCGv t0 = gen_ext_tl(reg, cpu_cc_dst, size, false);
tcg_gen_setcondi_tl(TCG_COND_EQ, reg, t0, 0);
and similarly for SF.
Paolo
- Re: [Qemu-devel] [PATCH 02/14] i386: introduce gen_ext_tl, (continued)
- [Qemu-devel] [PATCH 07/14] i386: add helper functions to get other flags, Paolo Bonzini, 2012/10/06
- [Qemu-devel] [PATCH 06/14] i386: factor gen_op_set_cc_op/tcg_gen_discard_tl around computing flags, Paolo Bonzini, 2012/10/06
- [Qemu-devel] [PATCH 09/14] i386: do not call helper to compute ZF/SF, Paolo Bonzini, 2012/10/06
- [Qemu-devel] [PATCH 08/14] i386: do not compute eflags multiple times consecutively, Paolo Bonzini, 2012/10/06
- [Qemu-devel] [PATCH 05/14] i386: move eflags computation closer to gen_op_set_cc_op, Paolo Bonzini, 2012/10/06
- [Qemu-devel] [PATCH 10/14] i386: use inverted setcond when computing NS or NZ, Paolo Bonzini, 2012/10/06
- [Qemu-devel] [PATCH 13/14] i386: optimize setbe, Paolo Bonzini, 2012/10/06