Re: [Qemu-devel] [RFC v1 3/7] memory: iommu support

[Avi Kivity]

On 10/11/2012 03:54 PM, Paolo Bonzini wrote:
> Il 11/10/2012 15:45, Avi Kivity ha scritto:
>>>> >> +struct MemoryRegionIOMMUOps {
>>>> >> +    /* Returns a TLB entry that contains a given address. */
>>>> >> +    IOMMUTLBEntry (*translate)(MemoryRegion *iommu, target_phys_addr_t 
>>>> >> addr,
>>>> >> +                               bool is_write);
>>>> >> +};
>>> > 
>>> > Do map/unmap still make sense in this model?  Ben & David, what were
>>> > your plans there?
>>> > 
>> Map/unmap is supported via address_space_map(), which calls
>> ->translate().  I don't see how a lower-level map/unmap helps, unless
>> the hardware supplies such a function.
> 
> Yep, it's just the map/unmap callbacks that are not supported anymore,
> but nobody uses that feature of DMAContext yet.

What do those callbacks it even mean?


-- 
error compiling committee.c: too many arguments to function