[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/6] linux-user: Rewrite __get_user/__put_user w
From: |
Riku Voipio |
Subject: |
Re: [Qemu-devel] [PATCH 4/6] linux-user: Rewrite __get_user/__put_user with __builtin_choose_expr |
Date: |
Fri, 12 Oct 2012 14:10:55 +0300 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
Hi,
On Thu, Oct 11, 2012 at 12:52:27PM -0700, Richard Henderson wrote:
> On 10/11/2012 12:22 PM, Richard Henderson wrote:
> > The previous formuation with multiple assignments to __typeof(*hptr) falls
> > down when hptr is qualified const. E.g. with const struct S *p, p->f is
> > also qualified const.
> >
> > With this formulation, there's no assignment to any local variable.
> >
> > Signed-off-by: Richard Henderson <address@hidden>
> Scratch that... I lost the unaligned access capability.
> I'll have to re-work the patch.
I've just prepared the rest of your patch for pending pull request[1].
Since changing __get_user/__put_user impacts more than just sigaction,
do you mind if we put this patch (and thus sigaction change as well)
to a later pull request?
Riku
[1]
http://git.linaro.org/gitweb?p=people/rikuvoipio/qemu.git;a=shortlog;h=refs/heads/linux-user-for-upstream