Re: [Qemu-devel] [PATCH 7/7] chardev: add hotplug support.

[Paolo Bonzini]

Il 12/10/2012 13:15, Gerd Hoffmann ha scritto:
>> > In principle you're right, but I think it's ugly that adding another
>> > chardev argument needs changes in 3 places instead of just one.
> Hmm, I don't have to use the generated marshaller, right?  With direct
> access to the QDict I could just transform it into a QemuOpts.

That's exactly what I was suggesting. :P

> A new parameter wouldn't need code changes then.  And the code would be 
> reusable and probably also be simpler.  The qapi schema still needs
> an update though.

The QAPI schema is only used by the generated marshaller.

> HMP is more tricky, but I think we should sort QMP first.

HMP can just take a string, parse it into QemuOpts, and call a small
wrapper that calls qemu_chr_new_from_opts and returns errors via Error.

Paolo