qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] chardev: add hotplug support.


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v2] chardev: add hotplug support.
Date: Fri, 12 Oct 2012 18:54:10 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121009 Thunderbird/16.0

Il 12/10/2012 14:39, Gerd Hoffmann ha scritto:
> +    chr = qemu_chr_new_from_opts(opts, NULL);
> +    if (chr == NULL) {
> +        qemu_opts_del(opts);
> +        error_setg(&err, "Creating chardev failed\n");
> +        goto exit_err;
> +    }
> +    return 0;
> +

Since you have to do a v3, please make this part (which is common
between HMP and QMP) a separate function.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]