Re: [Qemu-devel] [PATCH 0/3] vga: add mmio bar

[Blue Swirl]

On Thu, Oct 11, 2012 at 11:43 AM, Gerd Hoffmann <address@hidden> wrote:
> On 09/27/12 09:47, Gerd Hoffmann wrote:
>>   Hi,
>>
>> This patch series adds a mmio bar to the standard vga.  It also drops
>> a file into docs/specs/ describing the mmio bar and the other properties
>> of the qemu standard vga and does a little cleanup by removing
>> CONFIG_BOCHS_VBE.
>
> Ping?

Patches don't apply, please rebase:
Applying: vga: add mmio bar to standard vga
error: patch failed: hw/pc_piix.c:371
error: hw/pc_piix.c: patch does not apply
error: patch failed: hw/vga-pci.c:47
error: hw/vga-pci.c: patch does not apply
Patch failed at 0001 vga: add mmio bar to standard vga

Also checkpatch.pl complains for 1/3:
WARNING: suspect code indent for conditional statements (5, 9)
#212: FILE: hw/vga-pci.c:158:
+     if (d->flags & (1 << PCI_VGA_FLAG_ENABLE_MMIO)) {
+         memory_region_init(&d->mmio, "vga.mmio", 4096);

>
> cheers,
>   Gerd
>
>