[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/3] vga: add mmio bar
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 0/3] vga: add mmio bar |
Date: |
Mon, 15 Oct 2012 08:04:54 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.8) Gecko/20121006 Thunderbird/10.0.8 |
Hi,
> Patches don't apply, please rebase:
> Applying: vga: add mmio bar to standard vga
> error: patch failed: hw/pc_piix.c:371
> error: hw/pc_piix.c: patch does not apply
> error: patch failed: hw/vga-pci.c:47
> error: hw/vga-pci.c: patch does not apply
> Patch failed at 0001 vga: add mmio bar to standard vga
Rebased & resolved.
> Also checkpatch.pl complains for 1/3:
> WARNING: suspect code indent for conditional statements (5, 9)
> #212: FILE: hw/vga-pci.c:158:
> + if (d->flags & (1 << PCI_VGA_FLAG_ENABLE_MMIO)) {
> + memory_region_init(&d->mmio, "vga.mmio", 4096);
Ah, finally figured where this comes from. It's not in this patch, but
the *existing* intention is wrong (5 instead of 4 spaces). Fixed.
v2 is on the way.
cheers,
Gerd