Re: [Qemu-devel] [PATCH] qemu-img rebase: allow backing file to be specified as '-'

[Alex Bligh]

Eric,

--On 15 October 2012 13:28:11 -0600 Eric Blake <address@hidden> wrote:

> Missing a Signed-off-by; as such, it cannot be taken as is.

New patch sent under separate cover with Signed-Off-By: line.

> > @@ -1580,7 +1581,7 @@ static int img_rebase(int argc, char **argv)
> >     if (!unsafe) {
> >         uint64_t num_sectors;
> >         uint64_t old_backing_num_sectors;
> > -        uint64_t new_backing_num_sectors;
> > +        uint64_t new_backing_num_sectors=0;
>
> As long as you are touching this line, fix the indentation to be
> consistent (or is this unusual spacing an artifact of how you pasted
> your commit after your '-- ' signature rather than submitting it via
> 'git send-email' as a proper patch?).

I'm totally confused by the spacing artifact. The new patch was generated
with git-format-patch and git-send-email, and never touched a mailer (just
in case), and also shows under the same circumstances. It doesn't show the
bizarre indent in Mulberry, but does in Apple Mail. The patch applies
cleanly with git-am and doesn't moan about whitespace, and as far as I can
tell the resultant whitespace in the file is correct (i.e. matches the
preceding and subsequent lines).

> Also, most of qemu uses spaces on both sides of '='.

Fixed.

> But the overall idea looks nice.

Thanks

--
Alex Bligh