[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v1 0/7] IOMMU support
From: |
Avi Kivity |
Subject: |
Re: [Qemu-devel] [RFC v1 0/7] IOMMU support |
Date: |
Tue, 16 Oct 2012 11:30:18 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
On 10/15/2012 09:52 PM, Benjamin Herrenschmidt wrote:
>>
>> I do have an is_write parameter to translate, in fact I added it in
>> order to implement the spapr iommu. Or do you mean something else?
>
> Hrm, sort of. "is_write" means you can only express RO vs RW. Two
> parameter for read and write allow to express WO. The only difference is
> going to be if something does one translate for several R and W.
>
> Not a huge deal, since mostly translate is used for atomic accesses so
> one translate = one access... except with map. It's useful to
> differenciate the map with 3 states: RO, WO, RW.
address_space_rw() and address_space_map() can only by used for one
direction at the time (the first due to its API, the second because of
the need to bounce sometimes), so the current ->translate() signature is
okay for that. We can consider dropping the is_write parameter and
replacing it with permission bits in IOMMUTLBEntry, I think it's a
little more elegant (but no real advantage unless we start caching
IOMMUTLBEntries).
--
error compiling committee.c: too many arguments to function
- Re: [Qemu-devel] [RFC v1 7/7] vhost: abort if an emulated iommu is used, (continued)
- Re: [Qemu-devel] [RFC v1 7/7] vhost: abort if an emulated iommu is used, Avi Kivity, 2012/10/11
- Re: [Qemu-devel] [RFC v1 7/7] vhost: abort if an emulated iommu is used, Michael S. Tsirkin, 2012/10/11
- Re: [Qemu-devel] [RFC v1 7/7] vhost: abort if an emulated iommu is used, Avi Kivity, 2012/10/11
- Re: [Qemu-devel] [RFC v1 7/7] vhost: abort if an emulated iommu is used, Alex Williamson, 2012/10/11
- Re: [Qemu-devel] [RFC v1 7/7] vhost: abort if an emulated iommu is used, Avi Kivity, 2012/10/15
- Re: [Qemu-devel] [RFC v1 7/7] vhost: abort if an emulated iommu is used, liu ping fan, 2012/10/15
- Re: [Qemu-devel] [RFC v1 7/7] vhost: abort if an emulated iommu is used, Avi Kivity, 2012/10/15
Re: [Qemu-devel] [RFC v1 0/7] IOMMU support, Benjamin Herrenschmidt, 2012/10/11