qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCHv4] tests/tcg: fix build


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCHv4] tests/tcg: fix build
Date: Tue, 16 Oct 2012 20:54:16 +0100

On 16 October 2012 20:37, Catalin Patulea <address@hidden> wrote:
> Fixes compile line for test-x86_64 target as well.
>
> ---
> This broke when the tests were moved from tests/ to tests/tcg/.
>
> On x86_64 host/i386-linux-user non-kvm guest, test-i386 and test-mmap are 
> broken, but at least they build.
>
> To build/run the tests:
> $ cd $BUILD_PATH/tests/tcg
> $ SRC_PATH=path/to/qemu make <target>
> ---

This patch isn't in the right format to apply, I'm afraid.
Major problem:
 * missing signed-off-by line: we can't accept any patch
   without one
Minor problem:
 * the actual commit message is below the first '---' line,
   so 'git am' won't see it. Commit messages go above '---',
   "what I changed in this version' notes below.

'git format-patch' will produce things in the right format
(though you have to put the signed-off-by line in your commit
message yourself.)

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]