Re: [Qemu-devel] [PATCHv4] tests/tcg: fix build

[Peter Maydell]

On 16 October 2012 20:57, Catalin Patulea <address@hidden> wrote:
> On Tue, Oct 16, 2012 at 3:54 PM, Peter Maydell <address@hidden> wrote:
>> This patch isn't in the right format to apply, I'm afraid.
>> Major problem:
>>  * missing signed-off-by line: we can't accept any patch
>>    without one
>> Minor problem:
>>  * the actual commit message is below the first '---' line,
>>    so 'git am' won't see it. Commit messages go above '---',
>>    "what I changed in this version' notes below.
> I saw this format (notes, commit message, diffstat) on another list
> and assumed git am could handle this properly.
>
> It just seems strange to write the note somewhere *below* the commit
> message - the notes should be the first thing people read, and below
> them is the complete proposed patch. Is there any way to achieve that?

I think there may be options that permit that, but the default 'git am'
doesn't. Since people usually just 'git am' patch mails, we've had
the odd case before where the commit message has got mangled because
the email was in the wrong order.

A lot of this is basically community convention, so it differs
from project to project; this is just how qemu-devel does things.

Personally I like the "commit message first" bit -- that's the important
part that will stay around in git and needs to be a self-contained
description. The below the '---' notes are more like footnotes :-)

> Meanwhile, I'll reformat and resend the patch.

Thanks!

-- PMM