qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v11 09/14] target-mips: Add ASE DSP bit/manipula


From: Aurelien Jarno
Subject: Re: [Qemu-devel] [PATCH v11 09/14] target-mips: Add ASE DSP bit/manipulation instructions
Date: Wed, 17 Oct 2012 08:05:15 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Wed, Oct 17, 2012 at 11:44:41AM +0800, Jia Liu wrote:
> Hi Aurelien,
> 
> >> +#ifdef TARGET_MIPS64
> >> +    case OPC_ABSQ_S_QH_DSP:
> >> +        switch (op2) {
> >> +        case OPC_REPL_OB:
> >> +            check_dsp(ctx);
> >> +            {
> >> +                target_long temp;
> >> +
> >> +                imm = (ctx->opcode >> 16) & 0xFF;
> >> +                temp = imm;
> >> +                temp = (temp << 8) | temp;
> >> +                temp = (temp << 16) | temp;
> >> +                temp = (temp << 32) | temp;
> >> +                tcg_gen_movi_tl(cpu_gpr[ret], temp);
> >> +                break;
> >> +            }
> >
> > This hasn't been fixed, and thus is still wrong.
> >
> 
> Thank you for check this again.
> May you give me more comment about this please? I'm not sure what
> should do here.
> 

The instruction is defined as:

| Replicate a immediate byte into all elements of an eight byte vector.
|
| Description: rd ← immediate || immediate || immediate || immediate || 
immediate ||
|                   immediate || immediate || immediate

In your code, I only see the value replicated 4 times, not 8 times.


-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net



reply via email to

[Prev in Thread] Current Thread [Next in Thread]