Re: [Qemu-devel] [PATCH 02/18] qemu-sockets: add Error ** to all functions

[Markus Armbruster]

Paolo Bonzini <address@hidden> writes:

> Il 04/10/2012 18:19, Luiz Capitulino ha scritto:
>>> >  
>>> > -int unix_listen_opts(QemuOpts *opts)
>>> > +int unix_listen_opts(QemuOpts *opts, Error **errp)
>>> >  {
>>> > -    fprintf(stderr, "unix sockets are not available on windows\n");
>>> > +    error_setg(errp, "unix sockets are not available on windows");

Just gave me a "review WTF", too.

>> As we've discussed in a previous series, this breaks error reporting
>> for unix_listen_opts() until errp is passed _and_ the error is routed
>> to the right direction (in this case stderr).
>> 
>> Is this fixed later in this series? If it's not, when do you plan to fix it?
>
> It is (which is why the single patch became 18), and I can move this
> hunk at the end of the series.  Note that is just for Windows code and
> should really never run.

Fair enough, but a note in the commit message is in order.