Re: [Qemu-devel] [PATCHv2 1/2] signal: added a wrapper for sigprocmask function

[Peter Maydell]

On 17 October 2012 15:18, Alex Barcelo <address@hidden> wrote:
> Create a wrapper for signal mask changes initiated by the guest;
> this will give us a place to put code which prevents the guest
> from changing the handling of signals used by QEMU itself
> internally.
>
> The wrapper is called from all the guest-initiated sigprocmask, but
> is not called from internal qemu sigprocmask calls.
>
> Signed-off-by: Alex Barcelo <address@hidden>

In my comments on v1 of this patch I wrote:
"I think all the uses of sigprocmask() in linux-user/signal.c also
need to be do_sigprocmask(), as they are the guest trying to control
its signal mask (via the mask it specifies for running signal handlers,
or the mask it passes back when restoring context on return from a
signal handler)."

...but I don't see those changes here.

-- PMM