Re: [Qemu-devel] [PATCH 13/25] vnc: add error propagation to vnc_display_open

[Paolo Bonzini]

Il 17/10/2012 17:17, Markus Armbruster ha scritto:
>> > +fail:
>> > +    if (!error_is_set(errp)) {
>> > +        error_set(errp, QERR_VNC_SERVER_FAILED, display);
> How can we get here with no error set?
> 
> 1. !vnc_display (first goto fail).

This can be fixed up to give a separate error.

> 2. unit_connect() or inet_listen() return failure, but don't set error.
> 
> 3. unix_listen() or inet_listen() return failure, but don't set error.
> 
> Can 2. or 3. happen?
> 
> If yes, these functions suck.  If no, let's fix up 1. to set a suitable
> error, and drop the uninformative generic error here.
> 

It can at this point in the series, but not at the end.

I tried to split this one into many commits, but I wasn't sure it was
worth to make a mini-series out of one function.  In retrospect
 it was.

Paolo