Re: [Qemu-devel] [PATCH 3/8] block: bdrv_img_create(): move parameter list printing to qemu-img

[Kevin Wolf]

Am 18.10.2012 14:01, schrieb Kevin Wolf:
> Am 17.10.2012 21:35, schrieb Luiz Capitulino:
>> Today, bdrv_img_create() prints the parameter list used to create the
>> new image to stdout, like this:
>>
>>    Formatting '/tmp/a', fmt=qcow2 size=10737418240 encryption=off 
>> cluster_size=65536 lazy_refcounts=off
>>
>> As the transaction QMP command calls bdrv_img_create(), this message
>> is also printed when using QMP.
>>
>> This commit moves the printing of the parameter list to qemu-img instead.
>> This way we avoid printing it in QMP and from whatever bdrv_img_create()
>> usage we might have in the future.
>>
>> Signed-off-by: Luiz Capitulino <address@hidden>
> 
> I believe the idea was that this message is printed before actually
> creating the image, which in the case of preallocation could take a while.

The other thing is that I think you don't print the message any more
when creating the image fails. Did you check that qemu-iotests doesn't
need any updates?

Kevin