[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 27/45] qmp: add drive-mirror command
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 27/45] qmp: add drive-mirror command |
|
Date: |
Thu, 18 Oct 2012 15:13:52 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1 |
Il 15/10/2012 19:33, Kevin Wolf ha scritto:
>
>> > + source = bs->backing_hd;
>> > + if (!source && sync == MIRROR_SYNC_MODE_TOP) {
>> > + sync = MIRROR_SYNC_MODE_FULL;
>> > + }
>> > +
>> > + proto_drv = bdrv_find_protocol(target);
>> > + if (!proto_drv) {
>> > + error_set(errp, QERR_INVALID_BLOCK_FORMAT, format);
> Not a great error message for this case.
Hmm, this is cut-and-paste from qmp_transaction.
I will add an Error ** to bdrv_find_format and bdrv_find_protocol when I
have some time (certainly before 1.3).
Paolo