[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] target-arm: Implement abs_i32 inline rather
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] target-arm: Implement abs_i32 inline rather than as a helper |
|
Date: |
Thu, 18 Oct 2012 18:50:34 +0100 |
On 18 October 2012 18:40, malc <address@hidden> wrote:
> On Thu, 18 Oct 2012, Peter Maydell wrote:
>
> [..snip..]
>
>>
>> -/* FIXME: Implement this natively. */
>> -#define tcg_gen_abs_i32(t0, t1) gen_helper_abs(t0, t1)
>> +static void tcg_gen_abs_i32(TCGv dest, TCGv src)
>> +{
>> + TCGv c0 = tcg_const_i32(0);
>> + printf("tcg_gen_abs_i32\n");
>
> ^^^^^^ doubt it was intentional
Indeed, thanks. I seem to be making a lot of silly errors today...
-- PMM