Re: [Qemu-devel] [PATCH v3 10/16] qmp: add drive-mirror command

[Paolo Bonzini]

Il 19/10/2012 14:54, Kevin Wolf ha scritto:
>> > +    proto_drv = bdrv_find_protocol(target);
>> > +    if (!proto_drv) {
>> > +        error_set(errp, QERR_INVALID_BLOCK_FORMAT, format);
> This error message is still not fixed, and totally confusing, pointing
> at the wrong cause. No matter what changes to the error reporting we do
> later, we should add a better error string right now.

I think there's time for this before 1.3.  Either we fix everything in
this series, or since this is cut-and-paste we should not fix the pasted
occurrence.  Otherwise the fix will be harder to review and it's easier
to miss something.

Paolo