Re: [Qemu-devel] [Qemu-trivial] [PATCH 00/11] static patches

[Blue Swirl]

On Fri, Oct 19, 2012 at 8:38 AM, Stefan Hajnoczi <address@hidden> wrote:
> On Sun, Oct 14, 2012 at 07:58:48PM +0000, Blue Swirl wrote:
>> I made a small tool to detect unused functions and
>> variables. Here's some fixes.
>>
>> Blue Swirl (11):
>>   target-sparc: make do_unaligned_access static
>>   vl.c: add missing static
>>   vnc: add missing static and remove unused functions
>>   tap-win32: avoid a warning
>>   m48t59: remove unused m48t59_set_addr
>>   sun4c: remove unused functions
>>   slirp: remove unused function u_sleep
>>   ppc: add missing static and remove unused functions
>>   target-ppc: make some functions static
>>   arm: add missing static and remove unused functions
>>   exec: make some functions static
>>
>>  console.h                         |    2 -
>>  cpu-common.h                      |    5 -
>>  exec-all.h                        |    2 -
>>  exec-obsolete.h                   |    4 -
>>  exec.c                            |   19 ++-
>>  hw/adb.c                          |    8 +-
>>  hw/adb.h                          |    4 -
>>  hw/devices.h                      |    3 -
>>  hw/i2c.h                          |    3 -
>>  hw/m48t59.c                       |    7 -
>>  hw/mac_nvram.c                    |   24 ---
>>  hw/nvram.h                        |   12 --
>>  hw/omap.h                         |    1 -
>>  hw/omap_gpmc.c                    |   21 ---
>>  hw/pcmcia.h                       |    1 -
>>  hw/ppc.c                          |   54 +-----
>>  hw/ppc405.h                       |    6 -
>>  hw/ppc405_uc.c                    |  342 
>> -------------------------------------
>>  hw/ppc_mac.h                      |    2 -
>>  hw/pxa.h                          |    3 -
>>  hw/pxa2xx.c                       |    4 +-
>>  hw/pxa2xx_pcmcia.c                |   21 ---
>>  hw/soc_dma.c                      |   52 ------
>>  hw/soc_dma.h                      |   16 +--
>>  hw/sun4c_intctl.c                 |   23 ---
>>  hw/sun4m.h                        |    4 -
>>  hw/tc6393xb.c                     |   16 --
>>  hw/tmp105.c                       |   16 --
>>  linux-user/arm/nwfpe/fpa11.c      |    4 +-
>>  linux-user/arm/nwfpe/fpa11.h      |    2 -
>>  linux-user/arm/nwfpe/fpa11_cprt.c |    8 +-
>>  net/tap-win32.c                   |    1 +
>>  slirp/misc.c                      |   14 --
>>  slirp/misc.h                      |    1 -
>>  sysemu.h                          |    5 -
>>  target-ppc/cpu.h                  |    9 -
>>  target-ppc/mmu_helper.c           |   11 +-
>>  target-sparc/cpu.h                |    3 -
>>  target-sparc/ldst_helper.c        |    8 +-
>>  ui/vnc-jobs.c                     |   46 +-----
>>  ui/vnc-jobs.h                     |    4 -
>>  ui/vnc.c                          |   14 +-
>>  ui/vnc.h                          |    5 -
>>  vl.c                              |   33 ++---
>>  44 files changed, 69 insertions(+), 774 deletions(-)
>
> Will you send a v2 or will you drop this series?

I'll make a v2 with only 'static' patches and send function removal
patches separately.

>
> Stefan