[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 14/26] tcg: rework TCG helper flags
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v2 14/26] tcg: rework TCG helper flags |
Date: |
Sat, 20 Oct 2012 08:25:08 +1000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121009 Thunderbird/16.0 |
On 2012-10-20 06:24, Aurelien Jarno wrote:
> Agreed. On the other hand, the few lines just above the one your quoted
> would be more complicated:
>
> + if (!(call_flags & TCG_CALL_NO_READ_GLOBALS)) {
> + /* globals should be synced to memory */
> + memset(mem_temps, 1, s->nb_globals);
> + }
>
> would have to be written:
>
> + if (!(call_flags & TCG_CALL_NO_READ_WRITE_GLOBALS) ||
> + (call_flags & TCG_CALL_WRITE_GLOBALS)) {
> + /* globals should be synced to memory */
> + memset(mem_temps, 1, s->nb_globals);
> + }
>
> Note sure it makes the things clearer, and definitely not shorter.
Ah, didn't think of that. Oh well.
r~
[Qemu-devel] [PATCH v2 08/26] tcg: always mark dead input arguments as dead, Aurelien Jarno, 2012/10/09
[Qemu-devel] [PATCH v2 26/26] tcg: remove compatiblity call flags, Aurelien Jarno, 2012/10/09
[Qemu-devel] [PATCH v2 07/26] tcg: rewrite tcg_reg_alloc_mov(), Aurelien Jarno, 2012/10/09
[Qemu-devel] [PATCH v2 11/26] tcg: fix some op flags, Aurelien Jarno, 2012/10/09
[Qemu-devel] [PATCH v2 24/26] target-sparc: rename helper flags, Aurelien Jarno, 2012/10/09
[Qemu-devel] [PATCH v2 25/26] target-xtensa: rename helper flags, Aurelien Jarno, 2012/10/09