[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Revert "target-sparc: Make cpu_dst local to OP=
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH] Revert "target-sparc: Make cpu_dst local to OP=2 insns" |
|
Date: |
Sun, 21 Oct 2012 08:48:52 +1000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121009 Thunderbird/16.0 |
On 2012-10-21 00:48, Aurelien Jarno wrote:
> I am not sure it is the real problem, but at least the optimization of
> using the destination register as a temporary is wrong when the
> instruction might trigger an exception. In that case the result is
> written to the destination register while it should have not.
>
> This reverts commit 5793f2a47e201d251856c7956d6f7907ec0d9f1f.
Which insn might trigger an exception? Most OP=2 insns don't. There's
divide, but that's done out-of-line, so the assignment to dst does not
happen before the exception...
Is this sparc64? I assume so, since I did test sparc32...
r~