Re: [Qemu-devel] [PATCH 2/2] tcg/i386: remove ld/st third argument register constraint

[Richard Henderson]

On 2012-10-21 03:28, Aurelien Jarno wrote:
> On x86_64, remove the constraint on the third argument register which
> is not needed:
>  - For loads the helper arguments are env, addr, mem_idx. The addr
>    value should not be in the two first argument registers as they are
>    used in tcg_out_tlb_load().
>  - For stores the helper arguments are env, addr, data, mem_idx.
>    The addr and data values should not be in the two first argument
>    registers as they are used in tcg_out_tlb_load(). The data value
>    should also not be in the two first argument registers, but could
>    be in the third argument register in which case it would be already
>    loaded at the right location.
> 
> Signed-off-by: Aurelien Jarno <address@hidden>

Reviewed-by: Richard Henderson <address@hidden>


r~