Re: [Qemu-devel] [patch v4 11/16] vcpu: push mmio dispatcher out of big lock

[Avi Kivity]

On 10/22/2012 11:23 AM, Liu Ping Fan wrote:
> Signed-off-by: Liu Ping Fan <address@hidden>
> ---
>  kvm-all.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/kvm-all.c b/kvm-all.c
> index b3fa597..3d7ae18 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -1562,12 +1562,15 @@ int kvm_cpu_exec(CPUArchState *env)
>              break;
>          case KVM_EXIT_MMIO:
>              DPRINTF("handle_mmio\n");
> +            qemu_mutex_unlock_iothread();
>              set_context_type(1);
>              cpu_physical_memory_rw(run->mmio.phys_addr,
>                                     run->mmio.data,
>                                     run->mmio.len,
>                                     run->mmio.is_write);
>              set_context_type(0);
> +            qemu_mutex_lock_iothread();
> +
>              ret = 0;
>              break;
>          case KVM_EXIT_IRQ_WINDOW_OPEN:
> 

This is fine for now, but of course later we'll have to remove the lock
completely and apply it for the other exits (and other processing, when
needed).

-- 
error compiling committee.c: too many arguments to function