|
From: | Avi Kivity |
Subject: | Re: [Qemu-devel] [patch v4 13/16] e1000: add busy flag to anti broken device state |
Date: | Mon, 22 Oct 2012 12:40:25 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
On 10/22/2012 11:23 AM, Liu Ping Fan wrote: > The broken device state is caused by releasing local lock before acquiring > big lock. To fix this issue, we have two choice: > 1.use busy flag to protect the state > The drawback is that we will introduce independent busy flag for each > independent device's logic unit. > 2.reload the device's state > The drawback is if the call chain is too deep, the action to reload will > touch each layer. Also the reloading means to recaculate the intermediate > result based on device's regs. > > This patch adopt the solution 1 to fix the issue. Doesn't the nested mmio patch detect this? -- error compiling committee.c: too many arguments to function
[Prev in Thread] | Current Thread | [Next in Thread] |