[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 14/23] memory: manage coalesced mmio via a Me
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v3 14/23] memory: manage coalesced mmio via a MemoryListener |
Date: |
Mon, 22 Oct 2012 13:57:14 +0100 |
On 9 October 2012 17:32, Avi Kivity <address@hidden> wrote:
> Instead of calling a global function on coalesced mmio changes, which
> routes the call to kvm if enabled, add coalesced mmio hooks to
> MemoryListener and make kvm use that instead.
> -int kvm_coalesce_mmio_region(target_phys_addr_t start, ram_addr_t size)
> +static void kvm_coalesce_mmio_region(MemoryListener *listener,
> + MemoryRegionSection *secion,
> + target_phys_addr_t start, ram_addr_t
> size)
> {
> + void (*coalesced_mmio_add)(MemoryListener *listener, MemoryRegionSection
> *section,
> + target_phys_addr_t addr, target_phys_addr_t
> len);
These disagree about the type of the 'size/len' parameter, which means
this doesn't compile on 32-bit systems where target_phys_addr_t is 64
bits but ram_addr_t is 32 bits:
/home/petmay01/git/qemu/kvm-all.c:818:5: error: initialization from
incompatible pointer type [-Werror]
/home/petmay01/git/qemu/kvm-all.c:818:5: error: (near initialization
for ‘kvm_memory_listener.coalesced_mmio_add’) [-Werror]
/home/petmay01/git/qemu/kvm-all.c:819:5: error: initialization from
incompatible pointer type [-Werror]
/home/petmay01/git/qemu/kvm-all.c:819:5: error: (near initialization
for ‘kvm_memory_listener.coalesced_mmio_del’) [-Werror]
-- PMM
- [Qemu-devel] [PATCH v3 03/23] kvm: use separate MemoryListeners for memory and I/O, (continued)
- [Qemu-devel] [PATCH v3 03/23] kvm: use separate MemoryListeners for memory and I/O, Avi Kivity, 2012/10/09
- [Qemu-devel] [PATCH v3 04/23] xen_pt: use separate MemoryListeners for memory and I/O, Avi Kivity, 2012/10/09
- [Qemu-devel] [PATCH v3 08/23] memory: provide defaults for MemoryListener operations, Avi Kivity, 2012/10/09
- [Qemu-devel] [PATCH v3 09/23] memory: drop no-op MemoryListener callbacks, Avi Kivity, 2012/10/09
- [Qemu-devel] [PATCH v3 06/23] memory: export AddressSpace, Avi Kivity, 2012/10/09
- [Qemu-devel] [PATCH v3 17/23] memory: use AddressSpace for MemoryListener filtering, Avi Kivity, 2012/10/09
- [Qemu-devel] [PATCH v3 18/23] s390: avoid reaching into memory core internals, Avi Kivity, 2012/10/09
- [Qemu-devel] [PATCH v3 21/23] memory: add address_space_destroy(), Avi Kivity, 2012/10/09
- [Qemu-devel] [PATCH v3 22/23] pci: give each device its own address space, Avi Kivity, 2012/10/09
- [Qemu-devel] [PATCH v3 14/23] memory: manage coalesced mmio via a MemoryListener, Avi Kivity, 2012/10/09
- Re: [Qemu-devel] [PATCH v3 14/23] memory: manage coalesced mmio via a MemoryListener,
Peter Maydell <=
- [Qemu-devel] [PATCH v3 13/23] xen: drop no-op MemoryListener callbacks, Avi Kivity, 2012/10/09
- [Qemu-devel] [PATCH v3 07/23] memory: maintain a list of address spaces, Avi Kivity, 2012/10/09
- [Qemu-devel] [PATCH v3 15/23] memory: move address_space_memory and address_space_io out of memory core, Avi Kivity, 2012/10/09
- [Qemu-devel] [PATCH v3 23/23] pci: honor PCI_COMMAND_MASTER, Avi Kivity, 2012/10/09
[Qemu-devel] [PATCH v3 11/23] xen_pt: drop no-op MemoryListener callbacks, Avi Kivity, 2012/10/09