[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 00/29] qemu-sockets error propagation + NBD serve
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PULL 00/29] qemu-sockets error propagation + NBD server |
Date: |
Mon, 22 Oct 2012 17:59:27 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) |
Paolo Bonzini <address@hidden> writes:
> Anthony,
>
> The following changes since commit b6348f29d033d5a8a26f633d2ee94362595f32a4:
>
> target-arm/translate: Fix RRX operands (2012-10-17 19:56:46 +0200)
>
> are available in the git repository at:
>
> git://github.com/bonzini/qemu.git nbd-next
>
> for you to fetch changes up to 1f493f2c7ee75691c4ad22a7663f908924f464c5:
>
> qmp: add NBD server commands (2012-10-19 15:29:12 +0200)
>
> I and Luiz agreed that I would take care of sending it to you. It's been
> through his and Markus's review, and in particularly Markus suggested
> various improvements to the commit message and further splitting of
> some commits; the only remaining sore point was the HMP interface so I
> dropped it for now.
All my review comments have been addressed, except for a few nits. I
think the patch splitting added one error in 15/29, corrected in the
next patch. Fix that, and you've amply earned my
Reviewed-by: Markus Armbruster <address@hidden>
- [Qemu-devel] [PATCH 29/29] qmp: add NBD server commands, (continued)
- [Qemu-devel] [PATCH 29/29] qmp: add NBD server commands, Paolo Bonzini, 2012/10/19
- [Qemu-devel] [PATCH 13/29] vnc: avoid Yoda conditionals, Paolo Bonzini, 2012/10/19
- [Qemu-devel] [PATCH 24/29] qapi: add socket address types, Paolo Bonzini, 2012/10/19
- [Qemu-devel] [PATCH 28/29] block: add close notifiers, Paolo Bonzini, 2012/10/19
- [Qemu-devel] [PATCH 09/29] migration (incoming): add error propagation to fd and exec protocols, Paolo Bonzini, 2012/10/19
- [Qemu-devel] [PATCH 10/29] qemu-char: ask and print error information from qemu-sockets, Paolo Bonzini, 2012/10/19
- [Qemu-devel] [PATCH 18/29] qemu-sockets: add error propagation to inet_connect_addr, Paolo Bonzini, 2012/10/19
- [Qemu-devel] [PATCH 22/29] vnc: drop QERR_VNC_SERVER_FAILED, Paolo Bonzini, 2012/10/19
- [Qemu-devel] [PATCH 17/29] qemu-sockets: include strerror or gai_strerror output in error messages, Paolo Bonzini, 2012/10/19
- Re: [Qemu-devel] [PULL 00/29] qemu-sockets error propagation + NBD server,
Markus Armbruster <=
- Re: [Qemu-devel] [PULL 00/29] qemu-sockets error propagation + NBD server, Anthony Liguori, 2012/10/22
- Re: [Qemu-devel] [PULL 00/29] qemu-sockets error propagation + NBD server, Anthony Liguori, 2012/10/26