Re: [Qemu-devel] [PATCH v3 13/26] ich9: Add the lpc chip

[Isaku Yamahata]

On Mon, Oct 22, 2012 at 01:27:43PM +0200, Michael S. Tsirkin wrote:
> > diff --git a/hw/lpc_ich9.c b/hw/lpc_ich9.c
> > new file mode 100644
> > index 0000000..d9fd9de
> > --- /dev/null
> > +++ b/hw/lpc_ich9.c
> > @@ -0,0 +1,523 @@
> > +/*
> > + * Copyright (c) 2006 Fabrice Bellard
> > + *
> > + * Permission is hereby granted, free of charge, to any person obtaining a 
> > copy
> > + * of this software and associated documentation files (the "Software"), 
> > to deal
> > + * in the Software without restriction, including without limitation the 
> > rights
> > + * to use, copy, modify, merge, publish, distribute, sublicense, and/or 
> > sell
> > + * copies of the Software, and to permit persons to whom the Software is
> > + * furnished to do so, subject to the following conditions:
> > + *
> > + * The above copyright notice and this permission notice shall be included 
> > in
> > + * all copies or substantial portions of the Software.
> > + *
> > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS 
> > OR
> > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
> > + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR 
> > OTHER
> > + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING 
> > FROM,
> > + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS 
> > IN
> > + * THE SOFTWARE.
> > + */
> 
> Above is confusing until one notices the below "this is based on piix_pci.c"
> and looks at that file.
> 
> I think it's best to just use copyright Fabrice selected for all of this file.
> Jason, Isaku, could you please both respond whether it's OK with
> you both?

I'm fine with it. This applies to other files.
-- 
yamahata