Re: [Qemu-devel] [PATCH 16/37] target-i386: set kvm CPUID default feature values using static properties

[Andreas Färber]

Am 23.10.2012 12:40, schrieb Igor Mammedov:
> On Mon, 22 Oct 2012 19:20:10 -0400
> Don Slutz <address@hidden> wrote:
> 
>> On 10/22/12 11:03, Igor Mammedov wrote:
>>> Replace setting default supported kvm features in cpu_x86_find_by_name()
>>> by default values in corresponding static properties.
>>>
>>> - Compile in kvm CPUID features only if CONFIG_KVM is defined.
>>> - Make "f-kvm_steal_tm" and "f-kvmclock_stable" CPUID features visible as 
>>> properties.
>> Not sure that KVM_FEATURE_STEAL_TIME should translate to kvm_steal_tm.  
>> I think that I have seen that new names should use "-".  So I would 
>> think the new name should be "f-kvm-steal-time". And 
>> KVM_FEATURE_CLOCKSOURCE_STABLE_BIT should be "f-kvm-clock-stable".
> That would be inconsistent with current naming scheme, I may be it should be
> f-kvm_steal_time and f-kvm_clock_stable for this series and than later all
> the features converted in a single batch, its a bit out of scope of this
> patch. Alternatively a separate patch could be send to convert current
> feature name arrays to '-' scheme. I'll happily rebase series on top of it.

I am pretty sure that someone (not me) proposed to have all new
properties with dash and to translate the command line options from _ to -.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg