qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Rename target_phys_addr_t to hwaddr


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH] Rename target_phys_addr_t to hwaddr
Date: Tue, 23 Oct 2012 16:06:23 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1

Il 23/10/2012 14:55, Anthony Liguori ha scritto:
>> > target_phys_addr_t is unwieldly, violates the C standard (_t suffixes are
>> > reserved) and its purpose doesn't match the name (most target_phys_addr_t
>> > addresses are not target specific).  Replace it with a finger-friendly,
>> > standards conformant hwaddr.
>> >
>> > Outstanding patchsets can be fixed up with the command
>> >
>> >   git rebase -i --exec 'find -name "*.[ch]"
>> >                         | xargs s/target_phys_addr_t/hwaddr/g' origin
> We're getting pretty close to soft freeze so perhaps it's time to make a
> couple big changes.
> 
> Paolo, are you ready to do the file rename changes?  I'd like to
> coordinate this change with that one and do it all at the same time.

BTW,

$ git diffstat -M20 -C20 -l1500 --find-copies-harder origin/master.. | tail -1
1084 files changed, 4120 insertions(+), 5692 deletions(-)

(mostly due to moving around the include files, which is scripted).

$ git format-series -M20 -C20 -l1500 --find-copies-harder origin/master.. | wc 
-l
35346

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]