[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Rename target_phys_addr_t to hwaddr
From: |
Avi Kivity |
Subject: |
Re: [Qemu-devel] [PATCH] Rename target_phys_addr_t to hwaddr |
Date: |
Tue, 23 Oct 2012 16:50:31 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
On 10/23/2012 03:04 PM, Peter Maydell wrote:
> On 23 October 2012 11:30, Avi Kivity <address@hidden> wrote:
>> target_phys_addr_t is unwieldly, violates the C standard (_t suffixes are
>> reserved) and its purpose doesn't match the name (most target_phys_addr_t
>> addresses are not target specific). Replace it with a finger-friendly,
>> standards conformant hwaddr.
>>
>> Outstanding patchsets can be fixed up with the command
>>
>> git rebase -i --exec 'find -name "*.[ch]"
>> | xargs s/target_phys_addr_t/hwaddr/g' origin
>
> Isn't this command line missing a "sed" or something?
Yes.
--
error compiling committee.c: too many arguments to function