[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/7] ARM boards: don't prematurely explode QEMUM
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 0/7] ARM boards: don't prematurely explode QEMUMachineInitArgs |
Date: |
Wed, 24 Oct 2012 10:21:50 +0100 |
On 24 October 2012 09:42, Markus Armbruster <address@hidden> wrote:
> Peter Maydell <address@hidden> writes:
>
>> A lot of the ARM board models follow the pattern of having a
>> single common init function which is called with various
>> parameters from the QEMUMachine init function for several board
>> model variants. The change to QEMUMachineInitArgs in commit 5f072e
>> took the fairly mechanical approach of splitting the QEMUMachineInitArgs
>> fields out in each variant's init function to pass to an unchanged
>> common init function. This is a bit repetitive, so clean them up
>> to just pass the QEMUMachineInitArgs directly to the common
>> function instead.
>
> A quick grep finds similar cleanup opportunities in
>
> hw/exynos4_boards.c exynos4_boards_init_common()
> hw/pc_piix.c pc_init1()
> hw/sun4m.c sun4m_hw_init()
> hw/sun4u.c sun4uv_init()
> hw/xtensa_lx60.c lx_init()
> hw/xtensa_sim.c sim_init()
I deliberately stuck to the ARM boards on the basis that the
others were a little out of my jurisdiction. I missed the
exynos4 though.
-- PMM
- [Qemu-devel] [PATCH 0/7] ARM boards: don't prematurely explode QEMUMachineInitArgs, Peter Maydell, 2012/10/23
- [Qemu-devel] [PATCH 6/7] hw/nseries: Don't prematurely explode QEMUMachineInitArgs, Peter Maydell, 2012/10/23
- [Qemu-devel] [PATCH 1/7] hw/vexpress.c: Don't prematurely explode QEMUMachineInitArgs, Peter Maydell, 2012/10/23
- [Qemu-devel] [PATCH 5/7] hw/omap_sx1: Don't prematurely explode QEMUMachineInitArgs, Peter Maydell, 2012/10/23
- [Qemu-devel] [PATCH 7/7] hw/mainstone: Don't prematurely explode QEMUMachineInitArgs, Peter Maydell, 2012/10/23
- [Qemu-devel] [PATCH 4/7] hw/spitz: Don't prematurely explode QEMUMachineInitArgs, Peter Maydell, 2012/10/23
- [Qemu-devel] [PATCH 2/7] hw/realview.c: Don't prematurely explode QEMUMachineInitArgs, Peter Maydell, 2012/10/23
- [Qemu-devel] [PATCH 3/7] hw/versatilepb: Don't prematurely explode QEMUMachineInitArgs, Peter Maydell, 2012/10/23
- Re: [Qemu-devel] [PATCH 0/7] ARM boards: don't prematurely explode QEMUMachineInitArgs, Markus Armbruster, 2012/10/24