[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 09/27] pc: pc_init1(): get QEMUMachineInitArgs argum
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PATCH 09/27] pc: pc_init1(): get QEMUMachineInitArgs argument |
Date: |
Wed, 24 Oct 2012 15:49:43 -0200 |
Instead of passing each QEMUMachineInitArgs field individually, just
pass the whole QEMUMachineInitArgs object to pc_init1().
Signed-off-by: Eduardo Habkost <address@hidden>
---
hw/pc_piix.c | 47 ++++++++++++-----------------------------------
1 file changed, 12 insertions(+), 35 deletions(-)
diff --git a/hw/pc_piix.c b/hw/pc_piix.c
index 5093ce5..3eaed60 100644
--- a/hw/pc_piix.c
+++ b/hw/pc_piix.c
@@ -118,12 +118,7 @@ static void ioapic_init(GSIState *gsi_state)
}
/* PC hardware initialisation */
-static void pc_init1(ram_addr_t ram_size,
- const char *boot_device,
- const char *kernel_filename,
- const char *kernel_cmdline,
- const char *initrd_filename,
- const char *cpu_model,
+static void pc_init1(QEMUMachineInitArgs *args,
int pci_enabled,
int kvmclock_enabled)
{
@@ -148,6 +143,12 @@ static void pc_init1(ram_addr_t ram_size,
MemoryRegion *system_memory = get_system_memory();
MemoryRegion *system_io = get_system_io();
void *fw_cfg = NULL;
+ ram_addr_t ram_size = args->ram_size;
+ const char *cpu_model = args->cpu_model;
+ const char *kernel_filename = args->kernel_filename;
+ const char *kernel_cmdline = args->kernel_cmdline;
+ const char *initrd_filename = args->initrd_filename;
+ const char *boot_device = args->boot_device;
pc_cpus_init(cpu_model);
@@ -289,43 +290,19 @@ static void pc_init1(ram_addr_t ram_size,
static void pc_init_pci(QEMUMachineInitArgs *args)
{
- ram_addr_t ram_size = args->ram_size;
- const char *cpu_model = args->cpu_model;
- const char *kernel_filename = args->kernel_filename;
- const char *kernel_cmdline = args->kernel_cmdline;
- const char *initrd_filename = args->initrd_filename;
- const char *boot_device = args->boot_device;
- pc_init1(ram_size, boot_device,
- kernel_filename, kernel_cmdline,
- initrd_filename, cpu_model, 1, 1);
+ pc_init1(args, 1, 1);
}
static void pc_init_pci_no_kvmclock(QEMUMachineInitArgs *args)
{
- ram_addr_t ram_size = args->ram_size;
- const char *cpu_model = args->cpu_model;
- const char *kernel_filename = args->kernel_filename;
- const char *kernel_cmdline = args->kernel_cmdline;
- const char *initrd_filename = args->initrd_filename;
- const char *boot_device = args->boot_device;
- pc_init1(ram_size, boot_device,
- kernel_filename, kernel_cmdline,
- initrd_filename, cpu_model, 1, 0);
+ pc_init1(args, 1, 0);
}
static void pc_init_isa(QEMUMachineInitArgs *args)
{
- ram_addr_t ram_size = args->ram_size;
- const char *cpu_model = args->cpu_model;
- const char *kernel_filename = args->kernel_filename;
- const char *kernel_cmdline = args->kernel_cmdline;
- const char *initrd_filename = args->initrd_filename;
- const char *boot_device = args->boot_device;
- if (cpu_model == NULL)
- cpu_model = "486";
- pc_init1(ram_size, boot_device,
- kernel_filename, kernel_cmdline,
- initrd_filename, cpu_model, 0, 1);
+ if (args->cpu_model == NULL)
+ args->cpu_model = "486";
+ pc_init1(args, 0, 1);
}
#ifdef CONFIG_XEN
--
1.7.11.7
- [Qemu-devel] [PATCH 27/27] pc: generate APIC IDs according to CPU topology, (continued)
- [Qemu-devel] [PATCH 27/27] pc: generate APIC IDs according to CPU topology, Eduardo Habkost, 2012/10/24
- [Qemu-devel] [PATCH 06/27] target-i386: kvm: set vcpu_id to APIC ID instead of CPU index, Eduardo Habkost, 2012/10/24
- [Qemu-devel] [PATCH 22/27] pc: set CPU APIC ID explicitly, Eduardo Habkost, 2012/10/24
- [Qemu-devel] [PATCH 15/27] pc: rename bochs_bios_init() to pc_bios_init(), Eduardo Habkost, 2012/10/24
- [Qemu-devel] [PATCH 08/27] pc: pc_init1(): remove MemoryRegion arguments, Eduardo Habkost, 2012/10/24
- [Qemu-devel] [PATCH 18/27] pc: isolate the code that create CPUs, Eduardo Habkost, 2012/10/24
- [Qemu-devel] [PATCH 10/27] pc: create PCInitArgs struct, Eduardo Habkost, 2012/10/24
- [Qemu-devel] [PATCH 07/27] pc: pc_init1(): always use rom_memory on pc_memory_init() call, Eduardo Habkost, 2012/10/24
- [Qemu-devel] [PATCH 17/27] xen_machine_pv: use cpu_init() instead of cpu_x86_init(), Eduardo Habkost, 2012/10/24
- [Qemu-devel] [PATCH 13/27] pc: pass PCInitArgs struct to pc_memory_init(), Eduardo Habkost, 2012/10/24
- [Qemu-devel] [PATCH 09/27] pc: pc_init1(): get QEMUMachineInitArgs argument,
Eduardo Habkost <=
- [Qemu-devel] [PATCH 24/27] tests: support target-specific unit tests, Eduardo Habkost, 2012/10/24