qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] raltelimit bug


From: Eric Blake
Subject: Re: [Qemu-devel] raltelimit bug
Date: Wed, 24 Oct 2012 17:24:33 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1

On 10/24/2012 02:56 AM, Dietmar Maurer wrote:
> The code to compute slice_quota seems buggy. The following fixes the issue:
> 
> --- new.orig/include/qemu/ratelimit.h   2012-10-22 07:06:31.000000000 +0200

Missing a Signed-off-By, so it cannot be taken as-is.  See
http://wiki.qemu.org/Contribute/SubmitAPatch for hints.

> +++ new/include/qemu/ratelimit.h        2012-10-22 07:06:49.000000000 +0200
> @@ -42,7 +42,7 @@
>                                         uint64_t slice_ns)
>  {
>      limit->slice_ns = slice_ns;
> -    limit->slice_quota = ((double)speed * 1000000000ULL) / slice_ns;
> +    limit->slice_quota = ((double)speed * slice_ns)/1000000000ULL;
>  }
>  
>  #endif
> 
> 
> 
> 

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]