[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 3/8] usb/ehci: seperate out PCIisms
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [PATCH v1 3/8] usb/ehci: seperate out PCIisms |
|
Date: |
Thu, 25 Oct 2012 14:08:39 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.8) Gecko/20121012 Thunderbird/10.0.8 |
> +typedef struct EHCIItfState {
> + PCIDevice pcidev;
> + struct EHCIState ehci;
> +} EHCIItfState;
EHCIPCIState ?
> static const VMStateDescription vmstate_ehci = {
> .name = "ehci",
> - .version_id = 2,
> - .minimum_version_id = 1,
> + .version_id = 3,
> + .minimum_version_id = 2,
Pick a new name for this ...
> -static void ehci_class_init(ObjectClass *klass, void *data)
> +static const VMStateDescription vmstate_ehci_pci = {
> + .name = "ehci-pci",
... and keep using "ehci" here ...
> + .version_id = 3,
> + .minimum_version_id = 2,
... then you don't need to fiddle with the versions as the vmstate wire
format doesn't change then.
cheers,
Gerd
[Qemu-devel] [PATCH v1 4/8] usb/ehci: Add usb-ehci-sysbus, Peter Crosthwaite, 2012/10/25
[Qemu-devel] [PATCH v1 8/8] usb/ehci: Put RAM in undefined MMIO regions, Peter Crosthwaite, 2012/10/25