Re: [Qemu-devel] [PATCH v1 4/8] usb/ehci: Add usb-ehci-sysbus

[Peter Crosthwaite]

On Thu, Oct 25, 2012 at 10:10 PM, Gerd Hoffmann <address@hidden> wrote:
>>  typedef struct EHCIItfState {
>> -    PCIDevice pcidev;
>> +    /* FIXME: Figure out a better way to share one Property[] array between 
>> two
>> +     * QOM types with different parents
>> +     */
>> +    union {
>> +        PCIDevice pcidev;
>> +        SysBusDevice busdev;
>> +    };
>
> Ah, I see where this hack comes from.  I don't think they should share
> the properties in the first place ...
>

Kind of annoying to not share them as it really is a copy paste job
with the exception of the wrapping struct type.

> cheers,
>   Gerd
>