[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] qemu-char: Add new char backend CirMemCharD
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 1/4] qemu-char: Add new char backend CirMemCharDriver |
Date: |
Thu, 25 Oct 2012 13:59:52 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1 |
On 10/25/2012 01:48 PM, Lei Li wrote:
> Signed-off-by: Lei Li <address@hidden>
> ---
> qemu-char.c | 136
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> qemu-config.c | 3 +
> qemu-options.hx | 10 ++++
> 3 files changed, 149 insertions(+), 0 deletions(-)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index b082bae..45d2a86 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -99,6 +99,7 @@
> #include "ui/qemu-spice.h"
>
> #define READ_BUF_LEN 4096
> +#define CBUFF_SIZE 65536
>
> /***********************************************************/
> /* character device */
> @@ -2588,6 +2589,130 @@ size_t qemu_chr_mem_osize(const CharDriverState *chr)
> return d->outbuf_size;
> }
>
> +/*********************************************************/
> +/*CircularMemoryr chardev*/
s/CircularMemoryr/CircularMemory/
This typo was pointed out to you in v4; makes me wonder what else you
missed while preparing v5.
> @@ -1824,6 +1826,14 @@ the console, in pixels.
> @option{cols} and @option{rows} specify that the console be sized to fit a
> text
> console with the given dimensions.
>
> address@hidden -chardev memchr ,address@hidden ,address@hidden
> +
> +Create a circular buffer with fixed size indicated by optionally
> @option{maxcapacity}
> +which will be default 64K if it is not given.
> +
> address@hidden specify the max capacity of the size of circular buffer
> +want to create. Should be power of 2.
s/specify/specifies/
s/want//
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/4 V5] char: Add CirMemCharDriver and provide QMP interface, Lei Li, 2012/10/25
- [Qemu-devel] [PATCH 0/4 V5] char: Add CirMemCharDriver and provide QMP interface, Lei Li, 2012/10/25
- [Qemu-devel] [PATCH 1/4] qemu-char: Add new char backend CirMemCharDriver, Lei Li, 2012/10/25
- Re: [Qemu-devel] [PATCH 1/4] qemu-char: Add new char backend CirMemCharDriver,
Eric Blake <=
- [Qemu-devel] [PATCH 2/4] QAPI: Introduce memchar-write QMP command, Lei Li, 2012/10/25
- [Qemu-devel] [PATCH 3/4] QAPI: Introduce memchar-read QMP command, Lei Li, 2012/10/25
- [Qemu-devel] [PATCH 4/4] HMP: Introduce console command, Lei Li, 2012/10/25
- Re: [Qemu-devel] [PATCH 0/4 V5] char: Add CirMemCharDriver and provide QMP interface, Lei Li, 2012/10/26